Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort output of discover mojo (#630) #632

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Sort output of discover mojo (#630) #632

merged 1 commit into from
Sep 27, 2023

Conversation

Bananeweizen
Copy link
Contributor

@Bananeweizen Bananeweizen commented Sep 27, 2023 •
edited by timtebeek
Loading

  • sort just for output, not in any of the APIs returning the data
  • sort case insensitive, which is generally better suited for humans reading a list

What's changed?

Sort the lists produced by the discover mojo output for easier reading by humans.

What's your motivation?

Fixes #630

Looks like this now:
grafik

@Bananeweizen
Sort output of discover mojo (openrewrite#630)
db413a5 
* sort just for output, not in any of the APIs returning the data
* sort case insensitive, which is generally better suited for humans
reading a list
timtebeek
timtebeek approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix too!

@timtebeek timtebeek merged commit 5d48365 into openrewrite:main Sep 27, 2023
1 check passed
@timtebeek timtebeek added the enhancement New feature or request label Sep 27, 2023
@Bananeweizen Bananeweizen deleted the sort_discover branch September 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@Bananeweizen Bananeweizen

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort output of discover
2 participants
@Bananeweizen @timtebeek